Add RichObject support for SetupCheck descriptions #42585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
reviewed
Jan 9, 2024
Added a TODO to do that later, fixed the rest. |
come-nc
added
3. to review
come-nc
requested review from
susnux,
a team,
ArtificialOwl,
Altahrim and
sorbaugh
and removed request for
a team
susnux
approved these changes
Jan 9, 2024
Altahrim
approved these changes
Jan 11, 2024
come-nc
force-pushed
the
enh/add-rich-object-support-to-setupchecks
branch
2 times, most recently
from
108253a
to
dae9fa2
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com> Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/add-rich-object-support-to-setupchecks
branch
from
dae9fa2
to
e884ffd
Compare
|
/skjnldsv-backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow SetupCheck to pass rich parameters for description in SetupResult. Then UI can use that to render properly users and other elements.
TODO
OCP\RichObjectStrings\IValidatorrichToParsedmethod from notificationsChecklist