-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): use backend error message if provided #42598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
skjnldsv
force-pushed
the
fix/error-files-message
branch
2 times, most recently
from
January 5, 2024 16:16
f39b037
to
a70abc3
Compare
skjnldsv
requested review from
a team,
Fenn-CS and
szaimen
and removed request for
a team
January 5, 2024 16:16
szaimen
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
susnux
approved these changes
Jan 11, 2024
skjnldsv
force-pushed
the
fix/error-files-message
branch
from
January 11, 2024 16:22
a70abc3
to
01bf9fc
Compare
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 11, 2024
skjnldsv
force-pushed
the
fix/error-files-message
branch
from
January 11, 2024 16:24
01bf9fc
to
5424484
Compare
/backport 9296efa to stable28 |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/error-files-message
branch
from
January 12, 2024 09:14
5424484
to
e181fad
Compare
/backport 9296efa to stable28 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/backport to stable28
/skjnldsv-backport to stable28 |
2 tasks
/skjnldsv-backport 90d5032 to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
backport-request
bug
feature: files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42551
Followup: use the same handling for the drag and drop @susnux