Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Fix user status "Undefined array key 0 at StatusService.php… #42619

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

nickvergessen
Copy link
Member

#98"

  • Resolves hundred of issues we have in our log:
│[error] 2024-01-05T10:43:23.000 PHP              Undefined array key 0 at …/apps/dav/lib/CalDAV/Status/StatusService.php#98           │
 Received Time: 2024-01-05T10:43:23.000 -- 3 days ago                                                                                                                       │
 Known message fields for table nextcloud_log:                                                                                                                              │
 ├ reqId         = UJgUkgYIMW4vZQHZSA7X                                                                                                                                     │
 ├ level         = 3                                                                                                                                                        │
 ├ time          = 2024-01-05T10:43:23.000                                                                                                                                  │
 ├ remoteAddr    = 2a…                                                                                                                  │
 ├ user          = f…n                                                                                                                                                   │
 ├ app           = PHP                                                                                                                                                      │
 ├ method        = PUT                                                                                                                                                      │
 ├ url           = /ocs/v2.php/apps/user_status/api/v1/heartbeat?format=json                                                                                                │
 ├ body          = Undefined array key 0 at …/apps/dav/lib/CalDAV/Status/StatusService.php#98                                          │
 ├ message       = Undefined array key 0 at …/apps/dav/lib/CalDAV/Status/StatusService.php#98                                          │
 ├ userAgent     = Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:120.0) Gecko/20100101 Firefox/120.0                                                                     │
 ├ version       = 28.0.1.1                                                                                                                                                 │
 ├ data          = {"app":"PHP"}                                                                                                                                            │
 JSON fields:                                                                                                                                                               │
 ├ jget(data,'/app') = "PHP"                                                                                                                                                │
 Discovered fields for logline table from message format: Undefined array key # at #                                                                                        │
 ├ col_0 = 0                                                                                                                                                                │
 └ col_1 = …/apps/dav/lib/CalDAV/Status/StatusService.php#98  

Checklist

@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

Red CI is a regression from #42544

@joshtrichards
Copy link
Member

Possibly related / possibly fixes #42464

@tcitworld
Copy link
Member

Possibly related / possibly fixes #42464

This looks like it's close, but this fix shouldn't affect this issue.

…#98"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/caldav-status-undefined-index-0 branch from 09b3438 to e981619 Compare January 10, 2024 08:18
@nickvergessen
Copy link
Member Author

Rebasing for green CI

@nickvergessen nickvergessen merged commit eda8a41 into master Jan 15, 2024
49 of 50 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/caldav-status-undefined-index-0 branch January 15, 2024 07:53
@skjnldsv
Copy link
Member

/skjnldsv-backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants