Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated sysconfig 'enable_file_metadata' #42628

Merged
merged 1 commit into from
Mar 11, 2024
Merged

deprecated sysconfig 'enable_file_metadata' #42628

merged 1 commit into from
Mar 11, 2024

Conversation

ArtificialOwl
Copy link
Member

No description provided.

@ArtificialOwl ArtificialOwl requested review from artonge, a team, icewind1991 and Fenn-CS and removed request for a team January 8, 2024 13:52
@ArtificialOwl
Copy link
Member Author

/backport to stable28

@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Jan 10, 2024
@ArtificialOwl ArtificialOwl added this to the Nextcloud 29 milestone Jan 10, 2024
skjnldsv
skjnldsv requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add context to this?
Also this is not a deprecation, this is a complete removal? 🤔

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2024
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Mar 8, 2024 •
edited
Loading

Can you add context to this? Also this is not a deprecation, this is a complete removal? 🤔

This config flag was related to previous concept for metadata and it is not used anymore since the new API for Metadata

@ArtificialOwl ArtificialOwl force-pushed the fix/42627/deprecated-file-metadata-enabled branch from 15d5dfd to 3504591 Compare March 8, 2024 14:27
@ArtificialOwl ArtificialOwl force-pushed the fix/42627/deprecated-file-metadata-enabled branch from 3504591 to 9b880e7 Compare March 11, 2024 10:44
@ArtificialOwl
fix(config): deprecated enable_file_metadata
1d00d6c 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/42627/deprecated-file-metadata-enabled branch from 9b880e7 to 1d00d6c Compare March 11, 2024 11:21
@ArtificialOwl ArtificialOwl merged commit 2e30295 into master Mar 11, 2024
160 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/42627/deprecated-file-metadata-enabled branch March 11, 2024 12:00
@backportbot backportbot bot mentioned this pull request Mar 11, 2024
Merged
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@solracsf solracsf solracsf approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@ArtificialOwl @artonge @solracsf @skjnldsv