Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix styling of development-notice #42700

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jan 11, 2024

Close #42642

Before

Aufzeichnung.2024-01-11.114319.mp4

After

Aufzeichnung.2024-01-11.114018.mp4
For my own testing
docker run -it --rm ^
--name nextcloud-easy-test ^
-p 8443:443 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
-e SERVER_BRANCH=enh/42642/fix-development-notice-styling ^
-e COMPILE_SERVER=1 ^
-e VIEWER_BRANCH=master ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 29 milestone Jan 11, 2024
@szaimen szaimen force-pushed the enh/42642/fix-development-notice-styling branch from d3e0896 to 7e5f51e Compare January 11, 2024 10:35
@szaimen szaimen marked this pull request as ready for review January 11, 2024 10:43
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 11, 2024
@szaimen szaimen added the design Design, UI, UX, etc. label Jan 11, 2024
@susnux
Copy link
Contributor

susnux commented Jan 11, 2024

should we fix the icon? Probably missing filter: var(--primary-invert-if-dark) (or similar)

@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

should we fix the icon? Probably missing filter: var(--primary-invert-if-dark) (or similar)

Í fear this does not work here as the icon is no item but only a css class:
image

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

/compile

szaimen and others added 2 commits January 11, 2024 10:19
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@emoral435 emoral435 force-pushed the enh/42642/fix-development-notice-styling branch from 0ce5c15 to a6863ce Compare January 11, 2024 16:19
@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

/backport cf17267 to stable28

@szaimen szaimen disabled auto-merge January 11, 2024 17:22
@szaimen szaimen merged commit 07749e6 into master Jan 11, 2024
40 of 41 checks passed
@szaimen szaimen deleted the enh/42642/fix-development-notice-styling branch January 11, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: hover contrasts on links are not ok
4 participants