fix(files): use getSummaryFor for better files summary translations
#42716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
3. to review
|
/backport 11e21fb to stable28 |
artonge
approved these changes
Jan 11, 2024
ShGKme
approved these changes
Jan 11, 2024
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/summary-files
branch
from
11e21fb
to
fb8b42f
Compare
skjnldsv
added
4. to release
|
/backport 14da405 to stable28 |
This comment was marked as resolved.
This comment was marked as resolved.
|
/backport 14da405 to stable28 |
This comment was marked as resolved.
This comment was marked as resolved.
|
backport in #42734 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the old way was not l10n compliant, I created a dedicated more complete summary generation, for drag and drop, but the main files list was not using it
Discovered with #42674