Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Fix informative graphics contrast of user status icons #42732

Merged
merged 4 commits into from
Jan 24, 2024
Merged

fix(a11y): Fix informative graphics contrast of user status icons #42732

merged 4 commits into from
Jan 24, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 12, 2024 •
edited
Loading

Opening for review in advance

Summary

Before After
image image
image image
image image
image image

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Jan 12, 2024
@Pytal Pytal self-assigned this Jan 12, 2024
ShGKme
ShGKme approved these changes Jan 12, 2024
View reviewed changes
apps/user_status/src/UserStatus.vue Outdated Show resolved Hide resolved
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2024
@Antreesy Antreesy mentioned this pull request Jan 22, 2024
Closed
2 tasks
@nickvergessen

This comment was marked as resolved.

Sign in to view
@Pytal
fix(dashboard): Migrate to NcUserStatusIcon
693eb69 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(user_status): Migrate to NcUserStatusIcon
f060475 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(user_status): Remove unused styles + svgs
b61c13c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
5945af5 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Jan 24, 2024

/backport 693eb69 f060475 b61c13c to stable28

@Pytal Pytal enabled auto-merge January 24, 2024 00:43
@Pytal Pytal disabled auto-merge January 24, 2024 00:58
@Pytal Pytal enabled auto-merge January 24, 2024 01:04
@Pytal Pytal merged commit e8a67a7 into master Jan 24, 2024
44 checks passed
@Pytal Pytal deleted the fix/a11y/user-status-icons branch January 24, 2024 01:44
@backportbot backportbot bot mentioned this pull request Jan 24, 2024
Merged
1 task
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 emoral435 approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: status
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @nickvergessen @susnux @ShGKme @emoral435