-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete <h1>
settings heading
#42742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
changed the title
fix(files): Complete
fix(core): Complete Jan 13, 2024
<h1>
settings heading<h1>
settings heading
JuliaKirschenheuter
force-pushed
the
fix/41826-avoid_same_h1_and_h2_headings
branch
from
January 15, 2024 12:00
97cb20f
to
1f618fb
Compare
was approved by @jancborchardt |
JuliaKirschenheuter
requested review from
ShGKme,
susnux,
Pytal,
emoral435 and
szaimen
January 15, 2024 12:02
jancborchardt
approved these changes
Jan 15, 2024
ShGKme
reviewed
Jan 15, 2024
JuliaKirschenheuter
force-pushed
the
fix/41826-avoid_same_h1_and_h2_headings
branch
from
January 15, 2024 16:02
1f618fb
to
f79b6ff
Compare
JuliaKirschenheuter
changed the title
fix(core): Complete
Complete Jan 15, 2024
<h1>
settings heading<h1>
settings heading
artonge
approved these changes
Jan 15, 2024
ShGKme
reviewed
Jan 15, 2024
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/41826-avoid_same_h1_and_h2_headings
branch
from
January 16, 2024 08:24
f79b6ff
to
f6ec297
Compare
ShGKme
approved these changes
Jan 16, 2024
/backport to stable28 |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before:
<h1 class="hidden-visually" id="page-heading-level-1">Personal info</h1>
After:
<h1 class="hidden-visually" id="page-heading-level-1">Personal info: Personal settings</h1>
Checklist