Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete <h1> settings heading #42742

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 12, 2024

Summary

Before:

<h1 class="hidden-visually" id="page-heading-level-1">Personal info</h1>

After:

<h1 class="hidden-visually" id="page-heading-level-1">Personal info: Personal settings</h1>

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 12, 2024
@susnux susnux changed the title fix(files): Complete <h1> settings heading fix(core): Complete <h1> settings heading Jan 13, 2024
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41826-avoid_same_h1_and_h2_headings branch from 97cb20f to 1f618fb Compare January 15, 2024 12:00
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 15, 2024
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review January 15, 2024 12:01
@JuliaKirschenheuter
Copy link
Contributor Author

image

was approved by @jancborchardt

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41826-avoid_same_h1_and_h2_headings branch from 1f618fb to f79b6ff Compare January 15, 2024 16:02
@JuliaKirschenheuter JuliaKirschenheuter changed the title fix(core): Complete <h1> settings heading Complete <h1> settings heading Jan 15, 2024
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable28

@blizzz blizzz merged commit 5f0c406 into master Jan 16, 2024
49 of 50 checks passed
@blizzz blizzz deleted the fix/41826-avoid_same_h1_and_h2_headings branch January 16, 2024 13:29
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants