fix(db): Execute dirty reads on the primary node #42933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
nickvergessen,
icewind1991,
Altahrim,
juliushaertl and
sorbaugh
|
If a change is not clear for testers/reviewers I'm happy to clarify :) |
juliushaertl
approved these changes
Jan 23, 2024
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/db/dirty-read-on-primary
branch
from
a1da0a4
to
97152de
Compare
nickvergessen
approved these changes
Jan 31, 2024
10 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By introducing read replicas in 29+ we open the door for new read after write problems. That is, when we write on the primary and read on the replica and the replica hasn't received the data yet. This condition is logged for developer awareness. Until the dirty read is fixed by the developer, we should force the dirty read to happen on the primary. This guarantees consistency, while hurting performance due to more load on the primary.
Checklist