Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unified-search): Refactor header menu code #42978

Merged
merged 3 commits into from
Jan 23, 2024
Merged

fix(unified-search): Refactor header menu code #42978

merged 3 commits into from
Jan 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 20, 2024 •
edited
Loading

Summary

  1. Adjust styles for the header menu trigger to match the other entries
  2. Rename the header menu trigger class so it aligns with other entries
  3. Simplify some code (e.g. use type on NcButton instead of custom styles).

Screenshots

before after
Screenshot_20240120_035700 Screenshot_20240120_040022
Screenshot_20240120_035707 Screenshot_20240120_040029

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Jan 20, 2024
@susnux susnux mentioned this pull request Jan 20, 2024
Closed
@susnux
fix(unified-search): Refactor header menu entry
b37d492 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(core): Do not apply invert-color filter to unified search
ea19bc5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
4f75aca 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/refactor-unified-search branch from 481275c to 4f75aca Compare January 23, 2024 01:04
@emoral435 emoral435 mentioned this pull request Jan 23, 2024
Merged
2 tasks
@susnux susnux merged commit a09107a into master Jan 23, 2024
45 checks passed
@susnux susnux deleted the fix/refactor-unified-search branch January 23, 2024 16:21
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: search
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @Fenn-CS @Pytal @emoral435