Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Allow to connect to local address when checking for .mjs support #42999

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 21, 2024

Summary

Allow local address when checking for module javascript support, as the server will connect to itself.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Jan 21, 2024
@susnux susnux added this to the Nextcloud 29 milestone Jan 21, 2024
@susnux susnux requested review from solracsf, come-nc, a team, blizzz and Altahrim and removed request for a team January 21, 2024 19:16
@susnux
Copy link
Contributor Author

susnux commented Jan 21, 2024

/backport to stable28

…mjs` support

Also reduce the severity in case of a failed check to warning.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@solracsf

This comment was marked as resolved.

@skjnldsv
Copy link
Member

/backport! to stable28

@skjnldsv skjnldsv merged commit 4dc224f into master Jan 23, 2024
53 checks passed
@skjnldsv skjnldsv deleted the fix/mjs-setup-check-local branch January 23, 2024 14:13
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
Copy link

backportbot bot commented Jan 23, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/42999/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42999/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: v28 - Your webserver does not serve .mjs files using the JavaScript MIME type...
5 participants