Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps): Fix type information of app manager #43045

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

nickvergessen
Copy link
Member

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the return types to the method head (both interface and implementation).

@nickvergessen
Copy link
Member Author

Please add the return types to the method head (both interface and implementation).

Breaks public API, so not for now

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Context? Is this a regression?

@provokateurin
Copy link
Member

Breaks public API, so not for now

Why would it break something? If the data returned matches the type then it just adds additional information?

@nickvergessen
Copy link
Member Author

Context? Is this a regression?

I noticed the null at some point when stepping with the debugger through the code while looking into migration service.
Did not check for the history or context

Why would it break something?

Apps implementing the interface break.
We can have a look in a follow up but I would not backport that compared to this doc block change

@nickvergessen nickvergessen merged commit 7f1b980 into master Jan 23, 2024
52 of 53 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-type-info-in-appmanager branch January 23, 2024 10:00
@nickvergessen
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants