Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade @nextcloud/router to 2.2.1 #43093

Merged
merged 2 commits into from
Jan 25, 2024
Merged

chore: Upgrade @nextcloud/router to 2.2.1 #43093

merged 2 commits into from
Jan 25, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 24, 2024

Summary

davRemotePath from @nextcloud/files is initialized before OC.webroot is, due to OC/util.js is loaded (which uses @nextcloud/files) before OC/webroot.js.

Now @nextcloud/files call @nextcloud/router which required OC.webroot set. To fix this the 2.2.1 release of @nextcloud/router provides the webroot logic by itself.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Jan 24, 2024
@susnux susnux added this to the Nextcloud 29 milestone Jan 24, 2024
@susnux susnux requested a review from blizzz January 24, 2024 20:38
@blizzz blizzz removed their request for review January 25, 2024 10:13
@susnux susnux requested a review from ShGKme January 25, 2024 15:51
@susnux
Copy link
Contributor Author

susnux commented Jan 25, 2024

/compile

@susnux susnux enabled auto-merge January 25, 2024 15:51
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 25, 2024
@susnux susnux merged commit dd18010 into master Jan 25, 2024
53 checks passed
@susnux susnux deleted the fix/router-version branch January 25, 2024 19:19
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File selector not working via the legacy API on NC28
3 participants