Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Consistent sorting for folders before files (user configurable) #43147

Merged
merged 3 commits into from
Jan 27, 2024
Merged

fix(files): Consistent sorting for folders before files (user configurable) #43147

merged 3 commits into from
Jan 27, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 26, 2024 •
edited by skjnldsv
Loading

Summary

Make the sorting of folder before files consistent (not only when sorting by base name) and add it as a configurable option.

Screen cast

vokoscreenNG-2024-01-26_14-33-52.mp4

Checklist

@susnux susnux force-pushed the fix/files-unify-folder-before-files branch from 413f0dd to c1e217b Compare January 26, 2024 13:33
@susnux susnux added this to the Nextcloud 29 milestone Jan 26, 2024
@susnux
Copy link
Contributor Author

susnux commented Jan 26, 2024

@skjnldsv backport?

@susnux susnux force-pushed the fix/files-unify-folder-before-files branch from c1e217b to 5955070 Compare January 26, 2024 15:04
@skjnldsv
Copy link
Member

@skjnldsv backport?

yes

@susnux
Copy link
Contributor Author

susnux commented Jan 27, 2024

/backport to stable28

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2024
@susnux
fix(files): Consistent sorting for folders before files (user configu…
2cea4d7 
…rable)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
5e1c4f2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(cypress): Adjust files sorting tests
9052bc6 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/files-unify-folder-before-files branch from 5955070 to 9052bc6 Compare January 27, 2024 13:31
@susnux susnux merged commit 5eaac6d into master Jan 27, 2024
135 checks passed
@susnux susnux deleted the fix/files-unify-folder-before-files branch January 27, 2024 22:20
@backportbot backportbot bot mentioned this pull request Jan 27, 2024
Merged
3 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: Sorting of files and folders inconsistent in Web UI
3 participants
@susnux @skjnldsv @Pytal