fix(files): selected files actions position on scroll/with readme block #43172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport 7a63327 to stable28 |
skjnldsv
reviewed
Jan 30, 2024
|
|
||
| &.files-list__table--with-thead-overlay { | ||
| // Hide the table header below the overlay | ||
| margin-top: calc(-1 * var(--row-height)); |
There was a problem hiding this comment.
This is the place I dislike the most in mi solution 🙈
susnux
approved these changes
Jan 30, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/43149/files--table-header-actions-position
branch
from
513d329
to
e90e136
Compare
|
Rebased onto master, recompiled assets |
skjnldsv
added
4. to release
|
/backport f01e169 to stable28 |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
absolute->sticky- Cannot say what correcting position via negative margin is a beautiful solution, but I have no more ideas...
Screenshots
🏚️ Before
before-actions.mp4
🏡 After
after-actions.mp4
Also works on small screen (a11y size)
Checklist