Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use DI for Setup class and move away from deprecated methods #43191

Merged
merged 2 commits into from
Jan 30, 2024

chore: Cleanup Installer class as well

67e3ece
Select commit
Loading
Failed to load commit list.
Merged

fix: Use DI for Setup class and move away from deprecated methods #43191

chore: Cleanup Installer class as well
67e3ece
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 30, 2024 in 1s

17.30% of diff hit (target 49.49%)

View this Pull Request on Codecov

17.30% of diff hit (target 49.49%)

Annotations

Check warning on line 188 in apps/settings/lib/AppInfo/Application.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/AppInfo/Application.php#L188 

Added line #L188 was not covered by tests

Check warning on line 34 in apps/settings/lib/SetupChecks/DebugMode.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/SetupChecks/DebugMode.php#L34 

Added line #L34 was not covered by tests

Check warning on line 38 in apps/settings/lib/SetupChecks/DebugMode.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/SetupChecks/DebugMode.php#L38 

Added line #L38 was not covered by tests

Check warning on line 41 in apps/settings/lib/SetupChecks/DebugMode.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/SetupChecks/DebugMode.php#L40-L41 

Added lines #L40 - L41 were not covered by tests

Check warning on line 45 in apps/settings/lib/SetupChecks/DebugMode.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/SetupChecks/DebugMode.php#L44-L45 

Added lines #L44 - L45 were not covered by tests

Check warning on line 50 in apps/settings/lib/SetupChecks/DebugMode.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/SetupChecks/DebugMode.php#L48-L50 

Added lines #L48 - L50 were not covered by tests

Check warning on line 52 in apps/settings/lib/SetupChecks/DebugMode.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

apps/settings/lib/SetupChecks/DebugMode.php#L52 

Added line #L52 was not covered by tests

Check warning on line 59 in core/Command/Maintenance/Install.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/Command/Maintenance/Install.php#L59 

Added line #L59 was not covered by tests

Check warning on line 78 in core/Command/Maintenance/Install.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/Command/Maintenance/Install.php#L78 

Added line #L78 was not covered by tests

Check warning on line 202 in core/Command/Maintenance/Install.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/Command/Maintenance/Install.php#L202 

Added line #L202 was not covered by tests

Check warning on line 991 in lib/base.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/base.php#L991 

Added line #L991 was not covered by tests

Check warning on line 158 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L158 

Added line #L158 was not covered by tests

Check warning on line 161 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L161 

Added line #L161 was not covered by tests

Check warning on line 174 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L174 

Added line #L174 was not covered by tests

Check warning on line 491 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L491 

Added line #L491 was not covered by tests

Check warning on line 514 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L514 

Added line #L514 was not covered by tests

Check warning on line 519 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L518-L519 

Added lines #L518 - L519 were not covered by tests

Check warning on line 559 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L559 

Added line #L559 was not covered by tests

Check warning on line 567 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L567 

Added line #L567 was not covered by tests

Check warning on line 569 in lib/private/Installer.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Installer.php#L569 

Added line #L569 was not covered by tests

Check warning on line 104 in lib/private/Setup.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Setup.php#L104 

Added line #L104 was not covered by tests

Check warning on line 111 in lib/private/Setup.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Setup.php#L111 

Added line #L111 was not covered by tests

Check warning on line 193 in lib/private/Setup.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Setup.php#L193 

Added line #L193 was not covered by tests

Check warning on line 213 in lib/private/Setup.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Setup.php#L213 

Added line #L213 was not covered by tests

Check warning on line 261 in lib/private/Setup.php

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/private/Setup.php#L261 

Added line #L261 was not covered by tests
View more details on Codecov