Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix(Request): Catch exceptions in isTrustedProxy #43193

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 29, 2024

Backport of PR #42794

The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot backportbot bot added bug 3. to review Waiting for reviews php Pull requests that update Php code labels Jan 29, 2024
@backportbot backportbot bot added this to the Nextcloud 27.1.7 milestone Jan 29, 2024
@nickvergessen nickvergessen merged commit 5147fcb into stable27 Jan 30, 2024
35 of 37 checks passed
@nickvergessen nickvergessen deleted the backport/42794/stable27 branch January 30, 2024 10:33
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants