fix(provisioning_api): Translate exceptions shown in the frontend #43234
Conversation
susnux
added
bug
3. to review
susnux
requested review from
nickvergessen,
rakekniven,
juliushaertl and
Pytal
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1432,7 +1412,7 @@ public function removeFromGroup(string $userId, string $groupid): DataResponse { | |||
|
|
|||
| if (count($userSubAdminGroups) <= 1) { | |||
| // Subadmin must not be able to remove a user from all their subadmin groups. | |||
| throw new OCSException('Not viable to remove user from the last group you are SubAdmin of', 105); | |||
| throw new OCSException($this->l10n->t('Not viable to remove user from the last group you are SubAdmin of'), 105); | |||
There was a problem hiding this comment.
Here you use "SubAdmin" or "subadmin". Please align all occurences. My vote goes to "sub-admin"
btw. I do not get the meaning of this sentence:
There was a problem hiding this comment.
Here you use "SubAdmin" or "subadmin". Please align all occurences. My vote goes to "sub-admin"
Done ✅
There was a problem hiding this comment.
btw. I do not get the meaning of this sentence
If I understand this correctly a sub-admin is not allowed to remove a user from all groups that user is sub-admin of, meaning the user must stay sub-admin of at least one groupe (maybe @nickvergessen, as the author, can help)?
There was a problem hiding this comment.
yeah I think so, to avoid users that are managed by no one
susnux
force-pushed
the
fix/provisioning-exception-msgs
branch
2 times, most recently
from
46b36b7
to
5b5da71
Compare
susnux
force-pushed
the
fix/provisioning-exception-msgs
branch
from
5b5da71
to
8a25bee
Compare
susnux
dismissed
rakekniven’s stale review
Made wording consistent "sub-admin", please re-review
susnux
dismissed
nickvergessen’s stale review
Reverted to deprecated function, please re-review
susnux
force-pushed
the
fix/provisioning-exception-msgs
branch
from
8a25bee
to
4ea985b
Compare
|
@Pytal also added translations for the missing exceptions - at least if it makes sense. |
…eplace some deprecations Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/provisioning-exception-msgs
branch
from
4ea985b
to
a025611
Compare
Summary
This exception messages are used by the front end to be displayed to the user, using hint exceptions would be quite breaking as hint exceptions are handled as HTTP error 500 for OCS controllers.
But I think it should be ok to simply translate the messages as for programmatically usage you should not use the message but the status code.
Also fixed some minor deprecation issue.
Checklist