fix(tests): Make the cypress apps management test more reliable #43273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was able to reproduce most failures that I found for the apps.cy.ts test by adding sleeps in the right places:
Add
sleep(7);
as first line inserver/apps/settings/lib/Controller/AppSettingsController.php
Line 246 in b64ab5f
sleep(7);
as first line inserver/apps/settings/lib/Controller/AppSettingsController.php
Line 438 in b64ab5f
sleep(7);
as first line inserver/apps/settings/lib/Controller/AppSettingsController.php
Line 500 in b64ab5f
Checklist