Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): id -> ID #43332

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(i18n): id -> ID #43332

merged 2 commits into from
Feb 5, 2024

Conversation

rakekniven
Copy link
Member

Reported at Transifex

@rakekniven
fix(i18n): id -> ID
14a8507 
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Feb 4, 2024

You need to adjust the test case:

1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserFailedToGenerateUserID
Failed asserting that exception message 'Could not create non-existing user ID' contains 'Could not create non-existing user id'.

@rakekniven
Update UsersControllerTest.php
c951eea 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven
Copy link
Member Author

You need to adjust the test case

Done.

@susnux susnux requested review from a team, Fenn-CS and szaimen and removed request for a team February 5, 2024 07:27
@rakekniven rakekniven merged commit afb7e81 into master Feb 5, 2024
140 checks passed
@rakekniven rakekniven deleted the rakekniven-patch-3 branch February 5, 2024 07:57
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
2. developing Work in progress bug feature: language l10n and translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakekniven @susnux @szaimen