chore(perf): prevent unnecessary bundling of caniuse-lite #43394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Feb 6, 2024
susnux
approved these changes
Feb 6, 2024
st3iny
added
4. to release
ShGKme
approved these changes
Feb 6, 2024
The code that I removed from the bundle is not used at all so it's just an optimization. |
ShGKme
reviewed
Feb 6, 2024
st3iny
force-pushed
the
chore/perf/caniuse-lite
branch
from
9b4996a
to
5f83955
Compare
It does not support tree shaking as they are still building a cjs bundle. However, they bundle certain futures to separate smaller modules which we can take advantage of. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
chore/perf/caniuse-lite
branch
from
5f83955
to
dd4e057
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It does not support tree shaking as they are still building a cjs bundle. However, they bundle certain futures to separate smaller modules which we can take advantage of.
Saves us around 930 KB (prod bundle).
Checklist