Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_external) Redact sensitive S3 values #43440

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Feb 7, 2024

Summary

While troubleshooting another matter, noticed these weren't being redacted

  • Adds S3 key / secret / bucket to list of values redacted automatically when dumping files_external config via occ
  • Adjusted the redaction string to match the one we use for occ config:list system

Probably not critical enough to backport to stable28.

TODO

Checklist

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 29 milestone Feb 7, 2024
@joshtrichards joshtrichards changed the title fix(files_external) Add sensitive S3 values redacted by list command fix(files_external) Redact sensitive S3 values Feb 8, 2024
@joshtrichards joshtrichards merged commit e96cd54 into master Feb 9, 2024
148 checks passed
@joshtrichards joshtrichards deleted the fix/files-external-s3-redact-values branch February 9, 2024 21:01
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants