Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userstatus): add back 0 timestamp for status without message #43464

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Feb 8, 2024

Summary

When updating a status from automation, the old code set a timestamp for an empty message status such as DND updates for status automation.

Checklist

@miaulalala miaulalala added this to the Nextcloud 29 milestone Feb 8, 2024
@miaulalala miaulalala self-assigned this Feb 8, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable28

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the same code as in fix before 👀 Let's try it

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Feb 12, 2024
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/43089/empty-dashboard-userstatus branch from 34d17af to c071fbf Compare February 12, 2024 12:24
@miaulalala
Copy link
Contributor Author

miaulalala commented Feb 12, 2024

Drone failure unrelated OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges

@ChristophWurst can I haz force merge?

@ChristophWurst ChristophWurst merged commit 9192886 into master Feb 12, 2024
155 of 156 checks passed
@ChristophWurst ChristophWurst deleted the fix/43089/empty-dashboard-userstatus branch February 12, 2024 15:07
@nickvergessen
Copy link
Member

Could/should we add a unit test to have the case documented properly to avoid another back and forth when something else is misbehaving again?

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: Empty DND user statuses listed on dashboard
4 participants