-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(log): exit log() earlier if no crashreport registered #43529
enh(log): exit log() earlier if no crashreport registered #43529
Conversation
bf68594
to
18a6b62
Compare
(failing test not related) |
18a6b62
to
b9e0530
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break BeforeMessageLoggedEvent
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
b9e0530
to
5aff876
Compare
I added a |
5aff876
to
bf6cb92
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
bf6cb92
to
2232753
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log events still work
follow-up on the previous improvement from @juliushaertl : #35970
The idea is to avoid some formatting of the payload as soon as we know for sure that it will not be used