fix(dav): overwrite report method for subscription calendars #43539
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| } | ||
|
|
||
| public function propFind(PropFind $propFind, INode $node) { |
Check notice
Code scanning / Psalm
MissingReturnType Note
| if (isset($tzResult[$tzProp])) { | ||
| // This property contains a VCALENDAR with a single | ||
| // VTIMEZONE. | ||
| $vtimezoneObj = VObject\Reader::read($tzResult[$tzProp]); |
Check failure
Code scanning / Psalm
UndefinedClass Error
| @@ -118,6 +131,113 @@ | |||
| } | |||
| } | |||
|
|
|||
| public function report($reportName, $report, $path) { | |||
Check notice
Code scanning / Psalm
MissingReturnType Note
| @@ -118,6 +131,113 @@ | |||
| } | |||
| } | |||
|
|
|||
| public function report($reportName, $report, $path) { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
| @@ -118,6 +131,113 @@ | |||
| } | |||
| } | |||
|
|
|||
| public function report($reportName, $report, $path) { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
| @@ -118,6 +131,113 @@ | |||
| } | |||
| } | |||
|
|
|||
| public function report($reportName, $report, $path) { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
|
Superseded by #43698 |
Summary
PROPFIND and REPORT both don't return the proper Calendar class any longer because the object generated in beforeMethod:* is not kept but a fresh instance is initialised for each call on getNodeForPath.
Enabling caching for PROPFINDs allows the calendar list to render the holiday calendars again.
Since the calendar query report only handles ICalendarObjects , which the subscription class ISN'T, the REPORT is empty.
TODO
Checklist