Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(files_reminders): Allow clearing reminders #43560

Merged
merged 3 commits into from
Feb 14, 2024
Merged

enh(files_reminders): Allow clearing reminders #43560

merged 3 commits into from
Feb 14, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 14, 2024 •
edited
Loading

Summary

  • Provide reminder as a dav attribute
  • Allow clearing reminders (regression from migration to new FileAction API)
Screenshot
image

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Feb 14, 2024
@Pytal Pytal requested review from susnux and artonge February 14, 2024 00:19
@Pytal Pytal self-assigned this Feb 14, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner February 14, 2024 00:19
@Pytal Pytal enabled auto-merge February 14, 2024 00:22
@Pytal Pytal changed the title enh(files_remidners): Allow clearing reminders enh(files_reminders): Allow clearing reminders Feb 14, 2024
@susnux susnux added the pending documentation This pull request needs an associated documentation update label Feb 14, 2024
susnux
susnux approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but also add the property here:

https://github.com/nextcloud/documentation/blob/master/developer_manual/client_apis/WebDAV/basic.rst#supported-properties

skjnldsv
skjnldsv approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! :)

@Pytal
feat(files_reminders): Add propfind dav plugin
66f4c67 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh(files_reminders): Allow clearing reminders
e64b4fe 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
7d80872 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal merged commit 79f5cf2 into master Feb 14, 2024
159 checks passed
@Pytal Pytal deleted the enh/clear-file-reminders branch February 14, 2024 20:24
@Pytal Pytal mentioned this pull request Feb 15, 2024
Closed
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal mentioned this pull request Feb 15, 2024
Merged
@skjnldsv
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Feb 15, 2024
Closed
2 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@Pytal Pytal removed the pending documentation This pull request needs an associated documentation update label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews enhancement feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Allow clearing reminders on files
3 participants
@Pytal @skjnldsv @susnux