Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Deprecate old things for real #43581

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

nickvergessen
Copy link
Member

Psalm output before:

ERROR: InvalidDocblock - lib/public/Settings/IManager.php:40:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
	/**
	 * @since 9.1.0
	 * @depreacted 29.0.0 Use {@see self::SETTINGS_ADMIN} instead
	 */
	public const KEY_ADMIN_SETTINGS = 'admin';


ERROR: InvalidDocblock - lib/public/Settings/IManager.php:46:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
	/**
	 * @since 9.1.0
	 * @depreacted 29.0.0 Use {@see self::SETTINGS_ADMIN} instead
	 */
	public const KEY_ADMIN_SECTION = 'admin-section';


ERROR: InvalidDocblock - lib/public/Settings/IManager.php:52:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
	/**
	 * @since 13.0.0
	 * @depreacted 29.0.0 Use {@see self::SETTINGS_PERSONAL} instead
	 */
	public const KEY_PERSONAL_SETTINGS = 'personal';


ERROR: InvalidDocblock - lib/public/Settings/IManager.php:58:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
	/**
	 * @since 13.0.0
	 * @depreacted 29.0.0 Use {@see self::SETTINGS_PERSONAL} instead
	 */
	public const KEY_PERSONAL_SECTION = 'personal-section';


------------------------------
4 errors found
------------------------------

Follow up

  • Also enforce the @since for constants in OCP => Follow up PR as there are 223 failures 😱

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Feb 14, 2024
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Feb 14, 2024
@nickvergessen nickvergessen self-assigned this Feb 14, 2024
@nickvergessen nickvergessen changed the title Bugfix/noid/use real deprecation fix(settings): Deprecate old things for real Feb 14, 2024
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why commented out code was committed

build/psalm/OcpSinceChecker.php Outdated Show resolved Hide resolved
build/psalm/OcpSinceChecker.php Outdated Show resolved Hide resolved
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit f9db9a7 into master Feb 14, 2024
159 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/use-real-deprecation branch February 14, 2024 20:22
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants