-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log host/ip for access violation #43650
Log host/ip for access violation #43650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
I also added the hostName and port to the message. |
|
Uhm... Thanks for bringing that up. Iam not well experienced with testst and it feels wrong to hard-code the to-test IPs to the EDIT: Sorry, just read the PHPUnit docs right, that IS actually a part of a string... I will update the test to only contain the last part. |
… rules` Signed-off-by: Robin Kluth <Commifreak@users.noreply.github.com>
… rules` Signed-off-by: Robin Kluth <Commifreak@users.noreply.github.com>
Signed-off-by: Robin Kluth <Commifreak@users.noreply.github.com>
Signed-off-by: Robin Kluth <Commifreak@users.noreply.github.com>
84f7712
to
51739ad
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
During checking some
Host violates local access rules
I noticed, that there is no value being logged. This PR adds the affected Host/IP to the Exception.Checklist