Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added l10n translation prop to calendar component #43656

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Feb 19, 2024

Summary

  • ARIA best practices are to include the aria-label on the ul container instead of each individual li element.
  • Required PR changes where aria-label goes, and introduces a new prop to pass the translated label in
  • This PR passes in the translated string to the prop

🏡 After

firefox_qK1LrbD0SC

Checklist

@emoral435 emoral435 added this to the Nextcloud 29 milestone Feb 19, 2024
@emoral435 emoral435 self-assigned this Feb 19, 2024
@emoral435 emoral435 force-pushed the enh/settings-calendar/accessibility#4/add-aria-label-to-correct-spot branch from 9a7a0b1 to a0ae392 Compare February 19, 2024 15:04
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the enh/settings-calendar/accessibility#4/add-aria-label-to-correct-spot branch from a0ae392 to 0e6781e Compare February 21, 2024 17:48
@emoral435 emoral435 marked this pull request as ready for review February 21, 2024 17:48
@emoral435
Copy link
Contributor Author

/backport to stable28

@Pytal Pytal enabled auto-merge February 21, 2024 18:18
@Pytal Pytal merged commit ffdf49a into master Feb 21, 2024
96 of 100 checks passed
@Pytal Pytal deleted the enh/settings-calendar/accessibility#4/add-aria-label-to-correct-spot branch February 21, 2024 19:09
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants