feat: Restore unified search filtering in files view #43665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
2 times, most recently
from
0927358
to
c25d141
Compare
Fenn-CS
changed the title
Fenn-CS
added
feature: files
feature: search
3. to review
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
4 times, most recently
from
40c4407
to
165b352
Compare
skjnldsv
reviewed
Feb 28, 2024
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
from
165b352
to
c98f875
Compare
skjnldsv
approved these changes
Feb 28, 2024
skjnldsv
reviewed
Feb 28, 2024
emoral435
reviewed
Feb 28, 2024
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
2 times, most recently
from
892d7f4
to
e672776
Compare
emoral435
approved these changes
Feb 28, 2024
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
2 times, most recently
from
3dd45fc
to
87bbb08
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
2 times, most recently
from
4921e74
to
8cbbcef
Compare
|
/compile / |
The unified search emits, search events that other apps can subscribe to and react however they want to search queries, following 4b55594 and prior updates to migrate the Files app ui to vue.js that feature was broken. This commit reintroduces the feature using the current `FileList` implementation. This commit also adds some logging to an empty exception handler. Resolve : #43365 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
43365-unified-search-filter-view-fix
branch
from
fd6efbc
to
29c37af
Compare
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
added
4. to release
|
/backport to stable27 |
|
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/43665/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 29c37af4 19377fac
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43665/stable27Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
|
/backport 29c37af to stable28 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert removing search event handler in files app
Resolve : #43365