feat(core): Expose the confirm password endpoint #43668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
nickvergessen,
ChristophWurst,
bigcat88 and
come-nc
|
Ah of course this stills needs the frontend changes to work with the new endpoint. |
nickvergessen
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Fine by me, but I would prefer to add/duplicate it into https://github.com/nextcloud/server/blob/master/core/Controller/AppPasswordController.php to have it available as proper OCS API
Currently this is non breaking and nothing needs changes? Or am I missing something? |
bigcat88
approved these changes
Feb 20, 2024
|
You're both right, I thought I had converted it to OCS which is not true 😅 |
nickvergessen
approved these changes
Feb 20, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #[UseSession] | ||
| public function confirmUserPassword(string $password): DataResponse { | ||
| $loginName = $this->userSession->getLoginName(); | ||
| $loginResult = $this->userManager->checkPassword($loginName, $password); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
provokateurin
force-pushed
the
feat/core/expose-confirm-password-endpoint
branch
from
e4de634
to
8f91df8
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/core/expose-confirm-password-endpoint
branch
from
8f91df8
to
6243a94
Compare
Altahrim
approved these changes
Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try of #43000
Summary
This allows non-web clients to confirm the password in order to use endpoints that require it.
Checklist