Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(files_versions): improve and fix technical debt on Version.vue #43754

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

skjnldsv
Copy link
Member

After https://github.com/nextcloud/server/pull/43727/files#r1497933392

  • Do not import some methods that were not designed for the same purpose
  • Simplify code
  • Migrate to typescript
  • Cleanup and added comments

@skjnldsv skjnldsv requested review from a team, Fenn-CS, sorbaugh, susnux and artonge and removed request for a team February 22, 2024 09:15
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade ❤️

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@susnux
Copy link
Contributor

susnux commented Feb 23, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit c942fb5 into master Feb 23, 2024
97 checks passed
@skjnldsv skjnldsv deleted the fix/hasPermissions branch February 23, 2024 07:52
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants