Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Refactor appstore and user management code #43769

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 22, 2024

Summary

Some refactoring of code for user management and the appstore just to get the changes for my app discover PR small.
This refactors the code to use initial state instead of the custom solution.

image

Checklist

@susnux susnux force-pushed the enh/refactor-appstore branch 2 times, most recently from e24f968 to cbc0546 Compare February 22, 2024 17:17
@susnux susnux requested a review from Pytal February 22, 2024 17:17
…property

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… initial state

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Copy link
Contributor

Possible performance regression detected

Show Output
564 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries

@skjnldsv skjnldsv merged commit 2f09291 into master Feb 23, 2024
158 of 159 checks passed
@skjnldsv skjnldsv deleted the enh/refactor-appstore branch February 23, 2024 22:44
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants