fix: Enforce forbidden filename characters #43775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
icewind1991,
a team,
ArtificialOwl,
blizzz,
Altahrim and
provokateurin
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
force-pushed
the
enforce/forbidden_chars
branch
from
bef9e19
to
8e68a9f
Compare
susnux
force-pushed
the
enforce/forbidden_chars
branch
from
8e68a9f
to
83b7e48
Compare
skjnldsv
reviewed
Feb 23, 2024
susnux
force-pushed
the
enforce/forbidden_chars
branch
from
83b7e48
to
9644a53
Compare
skjnldsv
approved these changes
Feb 23, 2024
susnux
force-pushed
the
enforce/forbidden_chars
branch
from
9644a53
to
a50b05f
Compare
blizzz
approved these changes
Feb 27, 2024
susnux
force-pushed
the
enforce/forbidden_chars
branch
2 times, most recently
from
2a3e26a
to
bd71fd2
Compare
skjnldsv
added
the
4. to release
susnux
force-pushed
the
enforce/forbidden_chars
branch
from
bd71fd2
to
523ba1c
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
enforce/forbidden_chars
branch
from
523ba1c
to
1017f4f
Compare
Merged
|
Nice this can avoid some frustration ! Thanks for this. Any reasons that it is not backported to v27 & v28 ? |
This is a feature PR that introduced new API, so we can not backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up on #40585 to enforce this also from the backend side.
Checklist