Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow registration of advanced external share actions #43882

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: Allow registration of advanced external share actions #43882

merged 2 commits into from
Mar 6, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 28, 2024 •
edited
Loading

Summary

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Feb 28, 2024
@Pytal Pytal self-assigned this Feb 28, 2024
@Pytal Pytal changed the title feat: Move external share actions into advanced share settings feat: Allow registration of advanced external share actions Feb 29, 2024
@Pytal Pytal force-pushed the feat/ext-share-actions branch 2 times, most recently from 56708b4 to 8821ec2 Compare March 4, 2024 15:31
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 4, 2024
@Pytal Pytal requested review from skjnldsv and artonge March 4, 2024 15:35
@Pytal Pytal marked this pull request as ready for review March 4, 2024 15:35
@Pytal
Copy link
Member Author

Pytal commented Mar 4, 2024

We're using the non-public OCA API to keep the files_downloadlimit app separate as discussed :)

@Pytal Pytal requested review from susnux and Fenn-CS March 5, 2024 14:29
@Pytal
Copy link
Member Author

Pytal commented Mar 5, 2024

/compile amend /

@Pytal Pytal enabled auto-merge March 5, 2024 17:07
@Pytal Pytal disabled auto-merge March 6, 2024 11:04
@Pytal Pytal force-pushed the feat/ext-share-actions branch 3 times, most recently from 592649f to 2c0b278 Compare March 6, 2024 17:10
@Pytal @skjnldsv
feat: Allow registration of advanced external share actions
1260c85 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Mar 6, 2024
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 6, 2024
@Pytal @skjnldsv
chore: compile assets
7d98225 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv skjnldsv merged commit 9af67c3 into master Mar 6, 2024
4 of 5 checks passed
@skjnldsv skjnldsv deleted the feat/ext-share-actions branch March 6, 2024 20:26
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux Awaiting requested review from susnux

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: sharing
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Add advanced external share actions
3 participants
@Pytal @artonge @skjnldsv