-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): fix html structure on the profile page #43897
Merged
susnux
merged 2 commits into
master
from
fix/move_out_profile_picture_federation-action_from_the_heading_
Feb 29, 2024
Merged
fix(files): fix html structure on the profile page #43897
susnux
merged 2 commits into
master
from
fix/move_out_profile_picture_federation-action_from_the_heading_
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/compile / |
/backport to stable28 |
JuliaKirschenheuter
requested review from
ShGKme,
Pytal,
susnux and
emoral435
February 28, 2024 15:46
susnux
reviewed
Feb 28, 2024
susnux
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the wrong indention (I suspect wrong tab width) this looks fine
ShGKme
approved these changes
Feb 28, 2024
JuliaKirschenheuter
force-pushed
the
fix/move_out_profile_picture_federation-action_from_the_heading_
branch
from
February 28, 2024 16:04
e771887
to
67d0c1d
Compare
Pytal
previously requested changes
Feb 28, 2024
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/move_out_profile_picture_federation-action_from_the_heading_
branch
from
February 29, 2024 08:41
8b20bc3
to
4a63d0e
Compare
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
emoral435
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
susnux
deleted the
fix/move_out_profile_picture_federation-action_from_the_heading_
branch
February 29, 2024 13:42
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before a button was mistakenly inside of the heading. Now all headings are standalone headings and have no buttons and other interactive content inside.
Screenshots
Checklist