Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): fix html structure on the profile page #43897

Merged

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Feb 28, 2024

Summary

Before a button was mistakenly inside of the heading. Now all headings are standalone headings and have no buttons and other interactive content inside.

Screenshots

Before After
image Screenshot from 2024-02-28 16-42-24

Checklist

@JuliaKirschenheuter
Copy link
Contributor Author

/compile /

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable28

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the wrong indention (I suspect wrong tab width) this looks fine

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/move_out_profile_picture_federation-action_from_the_heading_ branch from e771887 to 67d0c1d Compare February 28, 2024 16:04
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/move_out_profile_picture_federation-action_from_the_heading_ branch from 8b20bc3 to 4a63d0e Compare February 29, 2024 08:41
@JuliaKirschenheuter
Copy link
Contributor Author

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@susnux susnux merged commit 4a75fb0 into master Feb 29, 2024
98 checks passed
@susnux susnux deleted the fix/move_out_profile_picture_federation-action_from_the_heading_ branch February 29, 2024 13:42
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants