-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): Make the AppScore component to use SVG icons #44028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3. to review
Waiting for reviews
feature: apps management
labels
Mar 6, 2024
susnux
force-pushed
the
feat/app-score-use-svg
branch
from
March 6, 2024 11:33
d62d7cc
to
150d428
Compare
szaimen
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine but didnt test
susnux
force-pushed
the
feat/app-score-use-svg
branch
from
March 6, 2024 11:42
150d428
to
61b1f4e
Compare
susnux
changed the title
feat(settings): Make the AppScorce component to use SVG icons
feat(settings): Make the AppScore component to use SVG icons
Mar 6, 2024
szaimen
reviewed
Mar 6, 2024
susnux
force-pushed
the
feat/app-score-use-svg
branch
from
March 6, 2024 14:15
61b1f4e
to
25a3715
Compare
szaimen
approved these changes
Mar 6, 2024
Pytal
reviewed
Mar 6, 2024
Pytal
approved these changes
Mar 6, 2024
susnux
force-pushed
the
feat/app-score-use-svg
branch
from
March 6, 2024 17:40
25a3715
to
e2091f8
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
feat/app-score-use-svg
branch
from
March 6, 2024 20:16
e2091f8
to
2308283
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use SVG icons instead of images for the app score component.
Checklist