Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Fix always empty disabled users list for subadmins #44140

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix(settings): Fix always empty disabled users list for subadmins #44140

merged 1 commit into from
Mar 12, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 12, 2024 •
edited
Loading

Summary

Checklist

@Pytal
fix(settings): Fix always empty disabled users list for subadmins
77d2d3c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 29 milestone Mar 12, 2024
@Pytal Pytal self-assigned this Mar 12, 2024
@Pytal
Copy link
Member Author

Pytal commented Mar 12, 2024

/backport to stable28

@Pytal Pytal enabled auto-merge March 12, 2024 00:24
@sorbaugh sorbaugh self-requested a review March 12, 2024 09:00
@Pytal Pytal merged commit c423973 into master Mar 12, 2024
160 checks passed
@Pytal Pytal deleted the fix/subadmin-disabled-users branch March 12, 2024 09:00
@backportbot backportbot bot mentioned this pull request Mar 12, 2024
Merged
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@walhallaRV
Copy link

Hi,
first of all: THANK YOU for the really fast fix now! GREAT ;)
second: can I use this fix already? Edit the regarding file manually in an existing NC (V28.0.3) without any risk?

Thanks and have a great day!

Walhalla

@susnux
Copy link
Contributor

susnux commented Mar 13, 2024

@walhallaRV yes you can try to patch this manually,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorbaugh sorbaugh sorbaugh approved these changes

@come-nc come-nc come-nc approved these changes

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Group admins cannot access Disabled users list any longer
5 participants
@Pytal @walhallaRV @susnux @sorbaugh @come-nc