fix(personal-files): correctly filters groupfolders now #44455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Altahrim
approved these changes
Mar 26, 2024
emoral435
force-pushed
the
emoral435/fix/personalfiles/filter-group-folders
branch
from
ef613ad
to
2df1d12
Compare
artonge
reviewed
Mar 26, 2024
| return isNotShared | ||
| export const isPersonalFile = function(node: File): Boolean { | ||
| // the type of mounts that determine whether the file is shared | ||
| const sharedMountTypes = ["group", "shared"] |
There was a problem hiding this comment.
Shouldn't it be any kind of mount point? Are external storage excluded?
There was a problem hiding this comment.
Perhaps. Is it not possible that these external storage's containing files still belong solely to the user? These mount types are more defined to be shared, so I think its best to leave it to these. It can change easily in the future though.
There was a problem hiding this comment.
True, but they are still not personal files as "files in your personal folder".
Maybe @nextcloud/designers can give us their opinion
emoral435
force-pushed
the
emoral435/fix/personalfiles/filter-group-folders
branch
from
2df1d12
to
65f533d
Compare
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435
force-pushed
the
emoral435/fix/personalfiles/filter-group-folders
branch
from
65f533d
to
aab79a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filesPersonal View contains groupfolders #44359Summary
Previously, group folders where not being filtered out through the personal files view.
With this change, this cleaned up the code a bit and now correctly filters what it did previously, and now group folders :)
Check the screen recording below to see it in effect!
firefox_RSOGgiqWVd.mp4
Checklist