Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Improved notification exceptions #44770

Merged
merged 6 commits into from
Apr 15, 2024
Merged

fix(notifications): Improved notification exceptions #44770

merged 6 commits into from
Apr 15, 2024

Commits on Apr 12, 2024

  1. fix(notifications): Add a dedicated exception when invalid values are… 

    … set

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    834bd13 View commit details
    Browse the repository at this point in the history

  2. fix(notifications): Add a dedicated exception when not all fields are… 

    … set while saving a notification

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2c6ecef View commit details
    Browse the repository at this point in the history

  3. fix(notifications): Add a dedicated exception when the notification i… 

    …s unknown to the notifier

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c8e4a29 View commit details
    Browse the repository at this point in the history

  4. fix(notifications): Add a dedicated exception when a notification was… 

    … not parsed completely

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0d0c2cd View commit details
    Browse the repository at this point in the history

  5. fix(notifications): Throw AlreadyProcessedException also from the man… 

    …ager when it's done

Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6545fed View commit details
    Browse the repository at this point in the history

  6. fix(notifications): Add a warning when using relative links 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8745254 View commit details
    Browse the repository at this point in the history