fix(session): Log when session_* calls are slow #46106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
approved these changes
Jun 25, 2024
Altahrim
approved these changes
Jun 25, 2024
ChristophWurst
force-pushed
the
fix/session/log-slow-session-calls
branch
2 times, most recently
from
cfd0c07
to
64f35b1
Compare
|
/backport to stable29 |
ChristophWurst
force-pushed
the
fix/session/log-slow-session-calls
branch
from
64f35b1
to
6c1d7ea
Compare
| $timeAfter = microtime(true); | ||
| $timeSpent = $timeAfter - $timeBefore; | ||
| if ($timeSpent > 0.1) { | ||
| $logLevel = match (true) { |
There was a problem hiding this comment.
should we add a function which takes the time list as an argument? :-X
Doing this in so many places already
There was a problem hiding this comment.
I'm not sure how this can be abstracted the best way. The thresholds do not always follow the same pattern. Sometimes it's linear, other times it's exponential.
nickvergessen
approved these changes
Jun 27, 2024
ChristophWurst
force-pushed
the
fix/session/log-slow-session-calls
branch
from
6c1d7ea
to
6fa5011
Compare
ChristophWurst
added
4. to release
|
Cypress is probably failing for unrelated reasons |
|
Odd that I cannot merge, but let me rebase again then 
|
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
juliushaertl
force-pushed
the
fix/session/log-slow-session-calls
branch
from
e7b15c8
to
2b38d6a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
session_start and friends can take a long time when the session is locked. This slows down Nextcloud. It might be a good idea to catch when this happens.
TODO
Checklist