Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make app menu overflow entries vertically aligned #47034

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 5, 2024

Summary

The name property expects a text and just adds basically a "heading" for the text, so lets instead just utilize the default slot.

image

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 5, 2024
@susnux susnux added this to the Nextcloud 30 milestone Aug 5, 2024
@susnux susnux mentioned this pull request Aug 5, 2024
28 tasks
This was referenced Aug 6, 2024
@st3iny
Copy link
Member

st3iny commented Aug 7, 2024

What happened here? :D

Over 100 commits doesn't look right.

@AndyScherzinger
Copy link
Member

@st3iny nope, I did a rebase but GH went nuts, showed the processing changes spinner next to the PR title and now this....
I'll try another rebase... Let's see what GH thinks about that then...

@AndyScherzinger
Copy link
Member

@susnux sorry for any mess I might have caused. Tryed to warp it up and get it merged. However currently I can't clone the repo or fetch latest changes on an existing checkout, nor do a git pull all of them fail against GH...

The `name` property expects a `text` and just adds basically a "heading" for the text,
so lets instead just utilize the default slot.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger
Copy link
Member

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit 749dc7d into master Aug 7, 2024
111 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/app-menu-overflow branch August 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants