[stable28] fix(files): Correctly validate new node name #47035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
susnux
changed the title
susnux
force-pushed
the
backport/46774/stable28
branch
from
7f3b516
to
c4ec230
Compare
susnux
approved these changes
Aug 21, 2024
susnux
force-pushed
the
backport/46774/stable28
branch
from
c4ec230
to
50a404c
Compare
Fenn-CS
approved these changes
Aug 21, 2024
|
Restarted cypress, but failure looked suspiciously related |
|
Failure related |
skjnldsv
added
2. developing
|
@skjnldsv what is the next step here? |
Fixing the tests 🤭🤭 |
|
@skjnldsv sorry I don't fully get what you mean. The reason I ask is because this is for a support ticket that is meeting the SLA soon. Can this please be merged? Or can you give me a date when it can to be merged? Or otherwise tell me a next step concretely (who does what when) |
|
@DaphneMuller should be in next maintenance releases |
susnux
force-pushed
the
backport/46774/stable28
branch
from
50a404c
to
27538b5
Compare
|
drone is unrelated |
susnux
added
4. to release
* Resolves #45409 This includes two fixes: 1. The name in the "new node" dialog is correctly selected (e.g. `file.txt` only `file` is selected by default), to allow quick naming 2. `@nextcloud/files` functions for filename validation are used, this allows to use new Nextcloud 30 capabilities (e.g. reserved names) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/46774/stable28
branch
from
27538b5
to
adbffd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46767
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.