Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(webauthn): Increase database column for public key id #47246

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[stable28] fix(webauthn): Increase database column for public key id #47246

merged 1 commit into from
Aug 29, 2024

Commits on Aug 27, 2024

  1. fix(webauthn): Increase database column for public key id 

    * Resolves #34476

There is no maximum length defined in the standard,
most common the length is between 128 and 200 characters,
but as we store it not in plain data but base64 encoded the length can grow about 1/3.
We had a regression with 'Nitrokey 3' which created IDs with 196 byte length -> 262 bytes encoded base64.
So to be save we increase the size to 512 bytes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d13c495 View commit details
    Browse the repository at this point in the history