fix(flow): cannot set custom user agent #47480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
nickvergessen,
a team,
artonge,
Fenn-CS and
sorbaugh
and removed request for
a team
|
/backport 0eeb459 to stable30 |
|
/backport 0eeb459 to stable29 |
|
/backport 0eeb459 to stable28 |
blizzz
changed the title
juliushaertl
approved these changes
Aug 26, 2024
artonge
approved these changes
Aug 26, 2024
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to set a (custom) user agent in a flow check, the values are immediately replaced with an empty string. This happened because an identifier was changed, but one occurrence was missed (#38170).
Checklist