fix: Fix inaccessible content on public pages due to overlapping footer #47649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
bug
3. to review
Pytal
requested review from
susnux,
Fenn-CS and
szaimen
and removed request for
a team
susnux
reviewed
Aug 30, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/footer-overlap
branch
from
989aa49
to
d43ec7d
Compare
|
/compile / |
Pytal
changed the title
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnux
approved these changes
Sep 5, 2024
Comment on lines
42
to
47
| #content { | ||
| min-height: var(--body-height, calc(100% - var(--footer-height))); | ||
| padding-block-end: var(--footer-height); | ||
| } | ||
|
|
||
| #app-content-vue { |
There was a problem hiding this comment.
(unrelated:)
This will be funny once we have Vue3 apps, then there is double the padding, as currently Vue2 will replace #content with #app-content-vue, while Vue3 does not replace the mount point but the inner HTML.
skjnldsv
approved these changes
Sep 6, 2024
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
3 tasks
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Adds a non-invasive script to set the correct styling whenever the footer overlaps the main content so it is still accessible by scrolling.
Previous non-dynamic footer height was set in #46784
Checklist