[stable28] fix: Use sha256 to hash arguments of background jobs #47776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database. Signed-off-by: Louis Chemineau <louis@chmn.me>
backportbot
bot
requested review from
AndyScherzinger,
provokateurin,
sorbaugh and
artonge
backportbot
bot
added
enhancement
3. to review
artonge
force-pushed
the
backport/47769/stable28
branch
2 times, most recently
from
204d75b
to
ba25daf
Compare
artonge
approved these changes
Sep 5, 2024
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
backport/47769/stable28
branch
from
ba25daf
to
7f742cb
Compare
AndyScherzinger
approved these changes
Sep 5, 2024
blizzz
previously requested changes
Sep 5, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
test failed three times, but cannot be relevant to the changes update: actually twice and different → merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #47769
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.