Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix having to resolve conflicts twice when dropping files #48331

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 24, 2024

Resolves

When dragging and dropping some files into a folder with identically named files, a conflict resolution dialog will pop up and after submitting your selection subsequent conflict dialogs will be shown for each file individually. We want to proceed with the users initial selection instead of repeating the conflict resolution.

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 31 milestone Sep 24, 2024
@Pytal Pytal self-assigned this Sep 24, 2024
@Pytal
Copy link
Member Author

Pytal commented Sep 24, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense (we should also implement recursive conflict resolution for internal moves similar we do with uploads).

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thanks for fixing this! :)

@szaimen szaimen merged commit 6befdd6 into master Sep 25, 2024
115 checks passed
@szaimen szaimen deleted the fix/duplicated-conflict-resolution branch September 25, 2024 10:05
@szaimen
Copy link
Contributor

szaimen commented Sep 25, 2024

/backport to stable30

@szaimen
Copy link
Contributor

szaimen commented Sep 25, 2024

/backport to stable29

@szaimen
Copy link
Contributor

szaimen commented Sep 25, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants