fix(files): handle empty view with error #48625
Open
+55
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles error during content fetching.
In Nextcloud 27 in case of an error it redirected to the
/
root and (sometimes) showed a toast message with an error.server/apps/files/js/filelist.js
Lines 2256 to 2296 in ba452f9
After migrating to Vue, there is no error handling. It just shows a folder as an empty folder.
It is especially confusing when it was supposed to be a valid link:
It looks like the folder is available, just empty.
I found redirecting to the root less convenient to a user in flavor of explicitly showing an error and a button to reload it.
But I'm not sure about the text/design.
Screenshots
Checklist