Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lock): Call the correct getTTL method #48685

Closed
wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

Summary

We are checking for TTL, not the lock type.

Fix:

OC\\Lock\\MemcacheLockingProvider::setTTL(): Argument #3 ($compare) must be of type ?int, string given

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: call correct method
@solracsf solracsf added this to the Nextcloud 31 milestone Oct 14, 2024
@solracsf solracsf self-assigned this Oct 14, 2024
@solracsf solracsf closed this Oct 14, 2024
@kesselb
Copy link
Contributor

kesselb commented Oct 14, 2024

Thanks!

I've spotted that error in a log recently, but didn't have the opportunity to follow up. I think the easiest solution is to remove the type hint for setTTL $compare as the underlying methods accept mixed.

@solracsf
Copy link
Member Author

Yeah I've realized it after submiting :)
I'll push another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants